[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[xiangfu]

From: Xiangfu Liu <xiangfu@sharism.cc>

Hi Wolfgang Denk

in my Ben Nanonote board. there is no flash. I got a error
about no "CONFIG_SYS_FLASH_BASE" define. so I move this 
line to "#ifndef CONFIG_SYS_NO_FLASH"

I have tested with "MAKEALL". no warning or error relate this
patch.

this patch is base on  [master] branch commit:
  1f82ff4777f360e92aa37bbbed647f7b9d9d2044


Signed-off-by: Xiangfu Liu <xiangfu@sharism.cc>
---
 arch/mips/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index b2d113e..0af09c6 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -349,9 +349,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	size = flash_init();
 	display_flash_config (size);
 	bd->bi_flashsize = size;
+	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #endif
 
-	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #if CONFIG_SYS_MONITOR_BASE == CONFIG_SYS_FLASH_BASE
 	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
 #else
-- 
1.7.1

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[Wolfgang Denk]

Dear xiangfu,

In message <1279510479-5285-1-git-send-email-xiangfu@openmobilefree.net> you wrote:
> From: Xiangfu Liu <xiangfu@sharism.cc>
> 
> Hi Wolfgang Denk
> 
> in my Ben Nanonote board. there is no flash. I got a error
> about no "CONFIG_SYS_FLASH_BASE" define. so I move this 
> line to "#ifndef CONFIG_SYS_NO_FLASH"

Is there any specific reason for posting the same message 4 times from
two different mail addresses?

Please stop doing this!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can fool some of the people all of the time, and You can fool all
of the people some of the time, but You can't fool mom.

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

["Xiangfu Liu(刘向富)"]

oh. very sorry about the same message.
the "git send-emails" give me some error.
so I thought the email don't sended.

thanks for let me know :)

On 07/20/2010 02:56 AM, Wolfgang Denk wrote:
> Dear xiangfu,
>
> In message<1279510479-5285-1-git-send-email-xiangfu@openmobilefree.net>  you wrote:
>> From: Xiangfu Liu<xiangfu@sharism.cc>
>>
>> Hi Wolfgang Denk
>>
>> in my Ben Nanonote board. there is no flash. I got a error
>> about no "CONFIG_SYS_FLASH_BASE" define. so I move this
>> line to "#ifndef CONFIG_SYS_NO_FLASH"
>
> Is there any specific reason for posting the same message 4 times from
> two different mail addresses?
>
> Please stop doing this!
>
> Best regards,
>
> Wolfgang Denk
>


-- 
Best Regards
Xiangfu Liu
http://www.openmobilefree.net

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[xiangfu]

From: Xiangfu Liu <xiangfu@sharism.cc>

Hi Wolfgang Denk

in my Ben Nanonote board. there is no flash. I got a error
about no "CONFIG_SYS_FLASH_BASE" define. so I move this 
line to "#ifndef CONFIG_SYS_NO_FLASH"

I have tested with "MAKEALL". no warning or error relate this
patch.

this patch is base on  [master] branch commit:
  1f82ff4777f360e92aa37bbbed647f7b9d9d2044


Signed-off-by: Xiangfu Liu <xiangfu@sharism.cc>
---
 arch/mips/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index b2d113e..0af09c6 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -349,9 +349,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	size = flash_init();
 	display_flash_config (size);
 	bd->bi_flashsize = size;
+	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #endif
 
-	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #if CONFIG_SYS_MONITOR_BASE == CONFIG_SYS_FLASH_BASE
 	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
 #else
-- 
1.7.1

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[xiangfu]

From: Xiangfu Liu <xiangfu@sharism.cc>

Hi Wolfgang Denk

in my Ben Nanonote board. there is no flash. I got a error
about no "CONFIG_SYS_FLASH_BASE" define. so I move this 
line to "#ifndef CONFIG_SYS_NO_FLASH"

I have tested with "MAKEALL". no warning or error relate this
patch.

this patch is base on  [master] branch commit:
  1f82ff4777f360e92aa37bbbed647f7b9d9d2044


Signed-off-by: Xiangfu Liu <xiangfu@sharism.cc>
---
 arch/mips/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index b2d113e..0af09c6 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -349,9 +349,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	size = flash_init();
 	display_flash_config (size);
 	bd->bi_flashsize = size;
+	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #endif
 
-	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #if CONFIG_SYS_MONITOR_BASE == CONFIG_SYS_FLASH_BASE
 	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
 #else
-- 
1.7.1

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[xiangfu]

From: Xiangfu Liu <xiangfu@sharism.cc>

Hi Wolfgang Denk

in my Ben Nanonote board. there is no flash. I got a error
about no "CONFIG_SYS_FLASH_BASE" define. so I move this 
line to "#ifndef CONFIG_SYS_NO_FLASH"

I have tested with "MAKEALL". no warning or error relate this
patch.

this patch is base on  [master] branch commit:
  1f82ff4777f360e92aa37bbbed647f7b9d9d2044


Signed-off-by: Xiangfu Liu <xiangfu@sharism.cc>
---
 arch/mips/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index b2d113e..0af09c6 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -349,9 +349,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
 	size = flash_init();
 	display_flash_config (size);
 	bd->bi_flashsize = size;
+	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #endif
 
-	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
 #if CONFIG_SYS_MONITOR_BASE == CONFIG_SYS_FLASH_BASE
 	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
 #else
-- 
1.7.1

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

[Wolfgang Denk]

Dear xiangfu,

In message <1279509256-4524-1-git-send-email-xiangfu@openmobilefree.net> you wrote:
>
> in my Ben Nanonote board. there is no flash. I got a error
> about no "CONFIG_SYS_FLASH_BASE" define. so I move this 
> line to "#ifndef CONFIG_SYS_NO_FLASH"
> 
> I have tested with "MAKEALL". no warning or error relate this
> patch.
> 
> this patch is base on  [master] branch commit:
>   1f82ff4777f360e92aa37bbbed647f7b9d9d2044
> 
> 
> Signed-off-by: Xiangfu Liu <xiangfu@sharism.cc>
> ---
>  arch/mips/lib/board.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
> index b2d113e..0af09c6 100644
> --- a/arch/mips/lib/board.c
> +++ b/arch/mips/lib/board.c
> @@ -349,9 +349,9 @@ void board_init_r (gd_t *id, ulong dest_addr)
>  	size = flash_init();
>  	display_flash_config (size);
>  	bd->bi_flashsize = size;
> +	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
>  #endif
>  
> -	bd->bi_flashstart = CONFIG_SYS_FLASH_BASE;
>  #if CONFIG_SYS_MONITOR_BASE == CONFIG_SYS_FLASH_BASE
>  	bd->bi_flashoffset = monitor_flash_len;	/* reserved area for U-Boot */
>  #else

This is not a good idea, as it will leave the bd->bi_flash* variables
uninitialized. Rather explicitly set these to 0, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't you know anything? I should have thought anyone knows that  who
knows anything about anything...      - Terry Pratchett, _Soul Music_

[U-Boot] [PATCH] move the flash setup to "#ifndef CONFIG_SYS_NO_FLASH"

["Xiangfu Liu(刘向富)"]

Hi

ok. I will set them to 0 in my board.

thanks.

On 07/20/2010 02:55 AM, Wolfgang Denk wrote:
> Dear xiangfu,
> This is not a good idea, as it will leave the bd->bi_flash* variables
> uninitialized. Rather explicitly set these to 0, please.
>
> Best regards,
>
> Wolfgang Denk
>


-- 
Best Regards
Xiangfu Liu
http://www.openmobilefree.net