public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <reinhard.meyer@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] drivers/net/enc28j60.c - generalisation, how?
Date: Mon, 26 Jul 2010 02:07:31 +0200	[thread overview]
Message-ID: <4C4CD1C3.6070105@emk-elektronik.de> (raw)
In-Reply-To: <AANLkTinMzDbLCNjhyXxjJfofDhCmXGhnbjL0KLVVgvAY@mail.gmail.com>

Ben Warren wrote:
> Hi Reinhard,
>
> On Sun, Jul 25, 2010 at 1:06 PM, Reinhard Meyer <
> reinhard.meyer at emk-elektronik.de> wrote:
>
>   
>> Mike Frysinger wrote:
>>     
>>> On Saturday, July 24, 2010 02:11:16 Reinhard Meyer wrote:
>>>
>>>       
>>>> I would like to generalize that driver and make it also
>>>> CONFIG_NET_MULTI-able.
>>>>
>>>>         
>>> someone already has ... look at the archives in december of 09
>>>
>>>       
>> Thanks for the hint Mike,
>> it seems the thread there has died, and the work left incomplete however.
>> But it gives a head start to complete it.
>> The main issue I had is already proposed in that thread: rename the old
>> driver and make a new one :)
>>
>>     
> Then that seems like the right approach.  Create the new driver, port the
> existing boards to use it and see if anybody cares.  If somebody responds,
> you've found a tester.  If not, there may be some boards in the tree that
> compile fine but don't run.  Not a problem I'd lose much sleep over.
>   
Hello Ben,
I can rename the current driver to like "enc28j60_lpc2292.c" and make the
two affected boards use it, so they still compile and work. I can't do 
those boards' maintainers work and add the required code to use the new 
driver and make a generic spi framework for the lpc2292. They currently 
use a very private spi approach.
Or I call the new driver something like "enc28j60_generic.c".
I am definitely not going to port the existing two lpc2292 boards to use 
the new enc28j60 driver.
Reinhard

  reply	other threads:[~2010-07-26  0:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24  6:11 [U-Boot] drivers/net/enc28j60.c - generalisation, how? Reinhard Meyer
2010-07-24 17:04 ` Wolfgang Denk
2010-07-25  6:16   ` Reinhard Meyer
2010-07-25 14:48 ` Mike Frysinger
2010-07-25 20:06   ` Reinhard Meyer
2010-07-25 20:40     ` Mike Frysinger
2010-07-26 19:53       ` Mike Frysinger
2010-07-25 22:49     ` Ben Warren
2010-07-26  0:07       ` Reinhard Meyer [this message]
2010-07-26  3:11         ` Mike Frysinger
2010-07-26  6:00           ` Reinhard Meyer
2010-07-26 14:51             ` Ben Warren
2010-07-27  7:18               ` Martin Krause
2010-07-27  7:28                 ` Reinhard Meyer
2010-07-27  8:52                   ` Martin Krause
2010-08-06 14:06               ` [U-Boot] [PATCH] NET: move legacy enc28j60.c to sidetrack as enc28j60_lpc2292.c Reinhard Meyer
2010-08-06 16:31                 ` Ben Warren
2010-08-06 16:42                   ` [U-Boot] [PATCH v2] " Reinhard Meyer
2010-08-31  6:00                     ` Ben Warren
2010-08-06 21:09                   ` [U-Boot] [PATCH] " Mike Frysinger
2010-08-06 23:01                     ` Reinhard Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4CD1C3.6070105@emk-elektronik.de \
    --to=reinhard.meyer@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox