From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Usage of bi_env ?
Date: Tue, 27 Jul 2010 18:38:37 +0200 [thread overview]
Message-ID: <4C4F0B8D.10303@googlemail.com> (raw)
In-Reply-To: <20100715212116.D922C153A7E@gemini.denx.de>
On 15.07.2010 23:21, Wolfgang Denk wrote:
> Dear Dirk Behme,
>
> In message<4C349814.2000804@googlemail.com> you wrote:
>> With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives:
>>
>> ...
>> env_t = 0x00000000
>> ...
>>
>> The code in common/cmd_bdinfo.c for this is
>>
>> bd_t *bd = gd->bd;
>> ...
>> print_num ("env_t", (ulong)bd->bi_env);
>>
>> While checking if 0 for this value is correct or not, it looks to me
>> that bi_env isn't set anywhere and is unused [1]. And it looks like
>> bi_env is printed only in the ARM version of bdinfo. Do I miss
>> anything here?
>
> You missed sending a patch that cleans this up :-)
Fixed some minutes ago ;)
Best regards
Dirk
prev parent reply other threads:[~2010-07-27 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 15:07 [U-Boot] Usage of bi_env ? Dirk Behme
2010-07-15 21:21 ` Wolfgang Denk
2010-07-27 16:38 ` Dirk Behme [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4F0B8D.10303@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox