From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH 14/19] nand_fsl_nfc: get rid of local var
Date: Fri, 30 Jul 2010 08:24:35 +0200 [thread overview]
Message-ID: <4C527023.8080807@denx.de> (raw)
In-Reply-To: <20100729114050.13a62e5e@schlenkerla.am.freescale.net>
Hello Scott,
Scott Wood wrote:
> On Thu, 29 Jul 2010 12:45:03 +0200
> Heiko Schocher <hs@denx.de> wrote:
>
>> If we have -fPIC enabled, this var leads in one entry in the
>> GOT. The result of this is that the image size is > 0x800.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>
> Acked-by: Scott Wood <scottwood@freescale.com>
>
>> diff --git a/nand_spl/nand_boot_fsl_nfc.c b/nand_spl/nand_boot_fsl_nfc.c
>> index 9720f6a..0543512 100644
>> --- a/nand_spl/nand_boot_fsl_nfc.c
>> +++ b/nand_spl/nand_boot_fsl_nfc.c
>> @@ -34,10 +34,9 @@
>> #include <asm/io.h>
>> #include <fsl_nfc.h>
>>
>> -struct fsl_nfc_regs *nfc;
>> -
>> static void nfc_wait_ready(void)
>> {
>> + struct fsl_nfc_regs *nfc = (void *)NFC_BASE_ADDR;
>
> Alternatively, would this work at file scope?
>
> static struct fsl_nfc_regs *const nfc = (void *)NFC_BASE_ADDR;
Great tip! Thanks, this works also, I fix this in version 2
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2010-07-30 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 10:45 [U-Boot] [RFC][PATCH 14/19] nand_fsl_nfc: get rid of local var Heiko Schocher
2010-07-29 16:40 ` Scott Wood
2010-07-30 6:24 ` Heiko Schocher [this message]
2010-08-03 10:15 ` [U-Boot] [RFC][PATCH v2 " Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C527023.8080807@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox