From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] update the MIPS u-boot.lds
Date: Tue, 03 Aug 2010 20:36:27 +0900 [thread overview]
Message-ID: <4C57FF3B.2080009@pobox.com> (raw)
In-Reply-To: <1280763000-8722-1-git-send-email-xiangfu@openmobilefree.net>
Thanks for following-up,
On 08/03/2010 12:30 AM, Xiangfu Liu wrote:
> From: Xiangfu Liu <xiangfu@sharism.cc>
>
> Hi Wolfgang
No greetings in the longlog, please. Such comments, supplements are
to go below the three-dashes (---):
>>From the document, if set all arguments in "OUTPUT_FORMAT"
> to "tradbigmips", then even add "-EL" to gcc we still get
> EB format.
>
> Signed-off-by: Xiangfu Liu <xiangfu@openmobilefree.net>
> ---
(Here...)
> board/dbau1x00/u-boot.lds | 2 +-
> board/gth2/u-boot.lds | 2 +-
> board/incaip/u-boot.lds | 2 +-
> board/pb1x00/u-boot.lds | 2 +-
> board/purple/u-boot.lds | 2 +-
> board/qemu-mips/u-boot.lds | 2 +-
> examples/standalone/mips.lds | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
[snip]
> diff --git a/board/pb1x00/u-boot.lds b/board/pb1x00/u-boot.lds
> index 9a6cd1b..3c4fbe3 100644
> --- a/board/pb1x00/u-boot.lds
> +++ b/board/pb1x00/u-boot.lds
> @@ -24,7 +24,7 @@
> /*
> OUTPUT_FORMAT("elf32-bigmips", "elf32-bigmips", "elf32-bigmips")
> */
> -OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradbigmips")
> +OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradlittlemips")
> OUTPUT_ARCH(mips)
> ENTRY(_start)
> SECTIONS
According to MAKEALL script, pb1000_config is only used in Little-
endian, so its default endian should be set to LE as well. I too
missed this point in my previous patch.
With fixing above nits, feel free to add:
Acked-by: Shinya Kuribayashi <skuribay@pobox.com>
Wolfgang: Could you take care of this patch (hopefully revised one)
directly into your master. The fix is obvious.
next prev parent reply other threads:[~2010-08-03 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 15:30 [U-Boot] [PATCH] update the MIPS u-boot.lds Xiangfu Liu
2010-08-03 11:36 ` Shinya Kuribayashi [this message]
2010-08-03 15:29 ` Xiangfu Liu
2010-08-04 1:06 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C57FF3B.2080009@pobox.com \
--to=skuribay@pobox.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox