[U-Boot] [PATCH] update the MIPS u-boot.lds

[U-Boot] [PATCH] update the MIPS u-boot.lds

[Xiangfu Liu]

From: Xiangfu Liu <xiangfu@sharism.cc>

Hi Wolfgang

[U-Boot] [PATCH] update the MIPS u-boot.lds

[Shinya Kuribayashi]

Thanks for following-up,

On 08/03/2010 12:30 AM, Xiangfu Liu wrote:
> From: Xiangfu Liu <xiangfu@sharism.cc>
> 
> Hi Wolfgang

No greetings in the longlog, please.  Such comments, supplements are
to go below the three-dashes (---):

>>From the document, if set all arguments in "OUTPUT_FORMAT"
> to "tradbigmips", then even add "-EL" to gcc we still get 
> EB format.
> 
> Signed-off-by: Xiangfu Liu <xiangfu@openmobilefree.net>
> ---

(Here...)

>  board/dbau1x00/u-boot.lds    |    2 +-
>  board/gth2/u-boot.lds        |    2 +-
>  board/incaip/u-boot.lds      |    2 +-
>  board/pb1x00/u-boot.lds      |    2 +-
>  board/purple/u-boot.lds      |    2 +-
>  board/qemu-mips/u-boot.lds   |    2 +-
>  examples/standalone/mips.lds |    2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
[snip]
> diff --git a/board/pb1x00/u-boot.lds b/board/pb1x00/u-boot.lds
> index 9a6cd1b..3c4fbe3 100644
> --- a/board/pb1x00/u-boot.lds
> +++ b/board/pb1x00/u-boot.lds
> @@ -24,7 +24,7 @@
>  /*
>  OUTPUT_FORMAT("elf32-bigmips", "elf32-bigmips", "elf32-bigmips")
>  */
> -OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradbigmips")
> +OUTPUT_FORMAT("elf32-tradbigmips", "elf32-tradbigmips", "elf32-tradlittlemips")
>  OUTPUT_ARCH(mips)
>  ENTRY(_start)
>  SECTIONS

According to MAKEALL script, pb1000_config is only used in Little-
endian, so its default endian should be set to LE as well.  I too
missed this point in my previous patch.

With fixing above nits, feel free to add:

Acked-by: Shinya Kuribayashi <skuribay@pobox.com>

Wolfgang: Could you take care of this patch (hopefully revised one)
directly into your master. The fix is obvious.

[U-Boot] [PATCH] update the MIPS u-boot.lds

[Xiangfu Liu]

Hi  Shinya

On 08/03/2010 07:36 PM, Shinya Kuribayashi wrote:
> Aconfccording to MAKEALL script, pb1000_ig is only used in Little-
> endian, so its default endian should be set to LE as well.  I too
> missed this point in my previous patch.
>

thanks.

> With fixing above nits, feel free to add:
>
> Acked-by: Shinya Kuribayashi<skuribay@pobox.com>
>
(by the way. I manually added this line to email.
is the another way to add "Acked-by" like "Signed-off-by" is "-s")

-- 
Best Regards
Xiangfu Liu
http://www.openmobilefree.net

[U-Boot] [PATCH] update the MIPS u-boot.lds

[Shinya Kuribayashi]

On 08/04/2010 12:29 AM, Xiangfu Liu wrote:
> On 08/03/2010 07:36 PM, Shinya Kuribayashi wrote:
>> Aconfccording to MAKEALL script, pb1000_ig is only used in Little-
>> endian, so its default endian should be set to LE as well.  I too
>> missed this point in my previous patch.
> 
> thanks.

You still forgot to fix this part:

| No greetings in the longlog, please.  Such comments, supplements are
| to go below the three-dashes (---):

In other words, please remove "Hi Wolfgang" line, and in this case
"v1:" and "v2:" at the same time.  The resulting longlog would be
like this:

<longlog>