From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Tue, 10 Aug 2010 22:23:56 +0200
Subject: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support
In-Reply-To: <AANLkTimxgTpdomQJPbVXJDUvzq2=TEh-VUAW4foJHnum@mail.gmail.com>
References: <1281046488-25187-1-git-send-email-john.rigby@linaro.org>
	<1281046488-25187-3-git-send-email-john.rigby@linaro.org>
	<AANLkTimxgTpdomQJPbVXJDUvzq2=TEh-VUAW4foJHnum@mail.gmail.com>
Message-ID: <4C61B55C.3000301@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 10/08/2010 21:44, Grant Likely a ?crit :

>>   #if defined(CONFIG_OF_LIBFDT)
>> -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
>> +#if defined(CONFIG_PPC) || \
>> +    defined(CONFIG_M68K) || \
>> +    defined(CONFIG_SPARC) || \
>> +    defined(CONFIG_ARM)
>
> There's got to be a better way to do this.  :-)

Reminds me of an issue I encountered in my orion5x ide support patch 
series where I also had modified a rather complex condition in 
cmd_ide.c, which determined whether swapping I/O byte reads was needed.

Wolfgang had asked me to replace with a condition on a single new 
CONFIG_IDE_SWAP_IO macro, which in turn had to be defined in various 
cpu, SoC or board config files.

The patch is there: 
<http://article.gmane.org/gmane.comp.boot-loaders.u-boot/82109/match=ide>

Maybe the same principle could apply here?

Amicalement,
-- 
Albert.