public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc5xxx_fec/motionpro: disable PHY initialization on motionpro board
Date: Thu, 12 Aug 2010 03:29:50 +0400	[thread overview]
Message-ID: <4C63326E.30205@emcraft.com> (raw)
In-Reply-To: <1281566050-5859-1-git-send-email-yanok@emcraft.com>

Hello All,

On 12.08.2010 02:34, Ilya Yanok wrote:
> Historically PHY intialization was disabled on motionpro board. Then
> at some point PHY init was enabled and only comment message was left.
>    

After looking once more at the history I've found that this problem was 
actually fixed by

commit c00125e07c1ebc125bab40e1e18bceed8be0c162
Author: Bartlomiej Sieka <tur@semihalf.com>
Date:   Sun May 27 16:58:45 2007 +0200

     MPC5XXX, Motion-PRO: Fix PHY initialization problem.

which uses RESET_PHY_R feature to fix PHY initialization late in the 
boot process.
But with drivers that initialize PHYs not during boot process but on the 
first access (I believe mpc5xxx_fec is not the only example) this 
RESET_PHY_R feature is completely broken. What would be the correct way 
to fix this? Should we add reset_phy() call in every driver that uses 
'lazy' PHY initialization?

Regards, Ilya.

      reply	other threads:[~2010-08-11 23:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 22:34 [U-Boot] [PATCH] mpc5xxx_fec/motionpro: disable PHY initialization on motionpro board Ilya Yanok
2010-08-11 23:29 ` Ilya Yanok [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C63326E.30205@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox