From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Date: Thu, 12 Aug 2010 03:29:50 +0400 Subject: [U-Boot] [PATCH] mpc5xxx_fec/motionpro: disable PHY initialization on motionpro board In-Reply-To: <1281566050-5859-1-git-send-email-yanok@emcraft.com> References: <1281566050-5859-1-git-send-email-yanok@emcraft.com> Message-ID: <4C63326E.30205@emcraft.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello All, On 12.08.2010 02:34, Ilya Yanok wrote: > Historically PHY intialization was disabled on motionpro board. Then > at some point PHY init was enabled and only comment message was left. > After looking once more at the history I've found that this problem was actually fixed by commit c00125e07c1ebc125bab40e1e18bceed8be0c162 Author: Bartlomiej Sieka Date: Sun May 27 16:58:45 2007 +0200 MPC5XXX, Motion-PRO: Fix PHY initialization problem. which uses RESET_PHY_R feature to fix PHY initialization late in the boot process. But with drivers that initialize PHYs not during boot process but on the first access (I believe mpc5xxx_fec is not the only example) this RESET_PHY_R feature is completely broken. What would be the correct way to fix this? Should we add reset_phy() call in every driver that uses 'lazy' PHY initialization? Regards, Ilya.