public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vitaly Kuzmichev <vkuzmichev@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB-CDC: wrong ep status used
Date: Thu, 12 Aug 2010 14:13:32 +0400	[thread overview]
Message-ID: <4C63C94C.5050303@mvista.com> (raw)
In-Reply-To: <1281562865-6586-1-git-send-email-sbabic@denx.de>

Hi Stefano,

On 08/12/2010 01:41 AM, Stefano Babic wrote:
>  #if defined(DEV_CONFIG_CDC)
>  	if (dev->status_ep) {
> -		dev->stat_req = usb_ep_alloc_request(gadget->ep0, GFP_KERNEL);
> -		dev->stat_req->buf = status_req;
> +		dev->stat_req = usb_ep_alloc_request(dev->status_ep, GFP_KERNEL);
>  		if (!dev->stat_req) {
>  			dev->stat_req->buf=NULL;
We get oops here!

> -			usb_ep_free_request (gadget->ep0, dev->req);
> +			usb_ep_free_request (dev->status_ep, dev->req);
>  
>  			goto fail;
>  		}
> +		dev->stat_req->buf = status_req;
>  		dev->stat_req->context = NULL;
>  	}
>  #endif

  reply	other threads:[~2010-08-12 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 21:41 [U-Boot] [PATCH] USB-CDC: wrong ep status used Stefano Babic
2010-08-12 10:13 ` Vitaly Kuzmichev [this message]
2010-08-12 12:28   ` Stefano Babic
2010-08-12 17:05     ` Sergei Shtylyov
2010-08-13  9:16       ` Vitaly Kuzmichev
2010-08-13  9:19         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C63C94C.5050303@mvista.com \
    --to=vkuzmichev@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox