From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 12 Aug 2010 14:35:07 +0400 Subject: [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c In-Reply-To: <1281562849-6548-1-git-send-email-sbabic@denx.de> References: <1281562849-6548-1-git-send-email-sbabic@denx.de> Message-ID: <4C63CE5B.9030707@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. Stefano Babic wrote: > The buffer for the status request must be word aligned > because it is accessed with 32 bit pointer in the > eth_status_complete function. You don't tell anything here about why the size of the array becomes 16x with your patch... > Signed-off-by: Stefano Babic > --- > drivers/usb/gadget/ether.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > index 313f15f..9f9b093 100644 > --- a/drivers/usb/gadget/ether.c > +++ b/drivers/usb/gadget/ether.c > @@ -684,7 +684,7 @@ static struct usb_gadget_strings stringtab = { > > /*============================================================================*/ > static u8 control_req[USB_BUFSIZ]; > -static u8 status_req[STATUS_BYTECOUNT]; > +static u8 status_req[STATUS_BYTECOUNT * 16] __attribute__ ((aligned(32))); WBR, Sergei