From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c
Date: Thu, 12 Aug 2010 14:21:33 +0200 [thread overview]
Message-ID: <4C63E74D.9090608@denx.de> (raw)
In-Reply-To: <4C63CE5B.9030707@mvista.com>
Sergei Shtylyov wrote:
> Hello.
>
Hi Sergej,
> Stefano Babic wrote:
>
>> The buffer for the status request must be word aligned
>> because it is accessed with 32 bit pointer in the
>> eth_status_complete function.
>
> You don't tell anything here about why the size of the array becomes
> 16x with your patch...
You are right, I missed to change the value back after some tests.
STATUS_BYTECOUNT is correct, it is 16 byte and take care of space for
data. I will change the size back.
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2010-08-12 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 21:40 [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c Stefano Babic
2010-08-12 10:35 ` Sergei Shtylyov
2010-08-12 12:21 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C63E74D.9090608@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox