From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support
Date: Fri, 13 Aug 2010 00:58:15 +0200 [thread overview]
Message-ID: <4C647C87.3030803@emk-elektronik.de> (raw)
In-Reply-To: <20100812205602.46E911536EF@gemini.denx.de>
Dear Remy Bohmer,
just some more observations:
1. The USB device port hardware in AT91SAM9* is called "UDP".
So files that are AT91 specific should have "udp" in their names,
not "udc". I know LinuX did do it wrong already...
2. At one part the header file for at9sam9261 is unconditionally
included, and none for the other at91 variants. Have you verified
that this is OK for all at91 variants? Besides that if so, the
common parts used should probably be moved to an extra at91_*.h
file.
3. I did not follow the whole USB patches, my concern is
what touches AT91, but please explain to me what for we need
a board under u-boot to be a USB device. Since u-boot per se
is not multitasking how is the traffic handled while
at the command prompt?
Which leads to:
4. Which hardware did you test that on, and what device
functionality?
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-08-12 22:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 17:36 [U-Boot] [PATCH 1/3] Integrate USB gadget layer and USB CDC driver layer Remy Bohmer
2010-08-12 17:36 ` [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support Remy Bohmer
2010-08-12 18:57 ` Reinhard Meyer
2010-08-12 19:50 ` Remy Bohmer
2010-08-12 20:56 ` Wolfgang Denk
2010-08-12 22:58 ` Reinhard Meyer [this message]
2010-08-13 9:14 ` Remy Bohmer
2010-08-13 10:55 ` Reinhard Meyer
2010-08-13 11:03 ` Remy Bohmer
2010-08-13 9:16 ` Remy Bohmer
2010-08-13 10:22 ` Wolfgang Denk
2010-08-13 11:18 ` Remy Bohmer
2010-08-13 14:04 ` Wolfgang Denk
2010-08-12 17:36 ` [U-Boot] [PATCH 3/3] Enable the use of Ethernet over USB (CDC) for the AT91SAM9261EK board Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C647C87.3030803@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox