From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuzmichev Date: Fri, 13 Aug 2010 14:17:45 +0400 Subject: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout In-Reply-To: <4C642903.3010307@mvista.com> References: <1281617086-21220-1-git-send-email-vkuzmichev@mvista.com> <1281617086-21220-4-git-send-email-vkuzmichev@mvista.com> <4C642903.3010307@mvista.com> Message-ID: <4C651BC9.9060008@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Sergei, Sergei Shtylyov wrote: >> - printf ("enable %s --> %d\n", >> + DEBUG(dev, "enable %s --> %d\n", > > Well, I think the coding style shouldbe consistent -- you either leave > the space before ( or remove it. And as U-Boot seems to follow the Linux > coding style now, it seems better to remove the space. Well, I would say: "either leave the space before ( or remove it from EVERYWHERE". I think that the last thing should be done as a separate patch. So I would like to keep the coding style that is in this file. Best regards, Vitaly.