From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 13 Aug 2010 15:30:38 +0200 Subject: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros In-Reply-To: <4C6544B9.3000503@mvista.com> References: <1281617086-21220-1-git-send-email-vkuzmichev@mvista.com> <1281704276-29115-1-git-send-email-vkuzmichev@mvista.com> <4C6542A3.5040009@dawes.za.net> <4C6544B9.3000503@mvista.com> Message-ID: <4C6548FE.4020902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Vitaly Kuzmichev wrote: > Hi, > > Rogan Dawes wrote: >>> +#define DEBUG >>> +#undef DEBUG >>> + >> Eh? > > Such thing is used to let someone know that this driver supports debug > output through native U-Boot macros. So one need to comment #undef to > compile ether.c with debug messages. > There are at least 67 files in U-Boot that use such construction. Well, but probably it is better to remove both lines. In the rest of u-boot, DEBUG is neither set or unset - you see only #ifdef DEBUG or #ifndef DEBUG. You have found the examples how we should not do... If you want to remember how to set the debug output, it should be enough to add a comments with "to enable the debugging, define DEBUG before common.h" or something like that. I vote to remove only the two lines... Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================