From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuzmichev Date: Fri, 13 Aug 2010 17:40:00 +0400 Subject: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros In-Reply-To: <4C6548FE.4020902@denx.de> References: <1281617086-21220-1-git-send-email-vkuzmichev@mvista.com> <1281704276-29115-1-git-send-email-vkuzmichev@mvista.com> <4C6542A3.5040009@dawes.za.net> <4C6544B9.3000503@mvista.com> <4C6548FE.4020902@denx.de> Message-ID: <4C654B30.9060106@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, Stefano Babic wrote: > If you want to remember how to set the debug output, it should be enough > to add a comments with "to enable the debugging, define DEBUG before > common.h" or something like that. I vote to remove only the two lines... Would not it be better to make one of the following? 1) #if 0 #define DEBUG #endif 2) #ifdef CONFIG_USB_ETH_DEBUG #define DEBUG #endif