[U-Boot] [PATCH] IDE: Don't assume there are always two devices per bus

Wolfgang Denk
2010-08-15T21:30:46Z

Dear Rogan Dawes,

In message <1281904542-11694-1-git-send-email-rogan@dawes.za.net> you wrote:
>
> -#define IDE_BUS(dev) (dev >> 1)
> +#define IDE_BUS(dev) (dev >> (CONFIG_SYS_IDE_MAXDEVICE / \
> + CONFIG_SYS_IDE_MAXBUS - 1))

Please add parens to make clear you really mean what you write.
Especially with the line wrapping this could easily be misread.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In Christianity neither morality nor religion come into contact with
reality at any point." - Friedrich Nietzsche