From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Sat, 14 Aug 2010 15:03:25 +0200
Subject: [U-Boot] [PATCH] Add mvsata support for the Sheevaplug devices
In-Reply-To: <4C6689CF.8010601@mvista.com>
References: <4C6635C1.2080507@gmail.com> <4C6689CF.8010601@mvista.com>
Message-ID: <4C66941D.1090601@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 14/08/2010 14:19, Sergei Shtylyov a ?crit :

>> +#define CONFIG_SYS_ATA_DATA_OFFSET	(0x0100)
>> +#define CONFIG_SYS_ATA_REG_OFFSET	(0x0100)
>> +#define CONFIG_SYS_ATA_ALT_OFFSET	(0x0100)
>
>      The parens are useless here.

As this code comes from the mvsata_ide driver introduction, Sergei's 
comment also applies to edminiv2, openrd_base and the upcoming dns323 
configs.

However, the fix is not necessarily an urgent one; and I think it could 
be handled only once for all orion5x boards including edminv2 and dns323 
if it is done within the SoC-specific configuration header file we've 
already discussed.

The fix could even apply to kirkwood too, if there was a good way of 
defining a driver-specific configuration file and then have it included 
from SoC-specific config files for orion5x and kirkwood. Where could 
such a driver-specifc config file live?

Amicalement,
-- 
Albert.