From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Make preparatory patches that initially have no effect?
Date: Sat, 14 Aug 2010 19:05:19 +0200 [thread overview]
Message-ID: <4C66CCCF.9080303@emk-elektronik.de> (raw)
In-Reply-To: <20100814143009.A18461606A5@gemini.denx.de>
Dear Wolfgang Denk,
>> If I add those discrete changes to each driver patch (where it
>> might actually belong), the incremental changes to some of
>> those files would require all those driver patches to be applied
>> in the right order to avoid conflicts.
>
> Yes, and? What's the problem with that?
None for me. Only for people that want to try out a single (driver)
patch.
For example at91_gpbr.h is required by two independent patches.
Of course, I could base both patches such that each one introduces
that file.
> Yes,m that's a bad idea. Please re-read the "patches" wiki page.
> Commits shall be atomic, and complete. Splitting stuff that
> belongstogether is a bad idea, and your first patch that adds unused
> stuff will be rejected because of that reason: adding unused stuff.
I know that, however it could be argued that adding header files to
describe an architectures' hardware is not exactly specific to a driver.
Thats why I asked....
Best Regards,
Reinhard
next prev parent reply other threads:[~2010-08-14 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 9:07 [U-Boot] Make preparatory patches that initially have no effect? Reinhard Meyer
2010-08-14 14:30 ` Wolfgang Denk
2010-08-14 17:05 ` Reinhard Meyer [this message]
2010-08-14 18:46 ` Wolfgang Denk
2010-08-14 19:30 ` [U-Boot] Struct SoC access (was:Make preparatory patches that initially have no effect?) Reinhard Meyer
2010-08-14 19:36 ` Mike Frysinger
2010-08-14 19:40 ` [U-Boot] Struct SoC access Reinhard Meyer
2010-08-14 20:48 ` Mike Frysinger
2010-08-14 19:41 ` [U-Boot] Struct SoC access (was:Make preparatory patches that initially have no effect?) Wolfgang Denk
2010-08-14 19:58 ` [U-Boot] Struct SoC access Reinhard Meyer
2010-08-14 20:47 ` Reinhard Meyer
2010-08-14 21:49 ` Wolfgang Denk
2010-08-14 21:47 ` Wolfgang Denk
2010-08-14 22:15 ` Reinhard Meyer
2010-08-16 20:21 ` Scott Wood
2010-08-17 6:58 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C66CCCF.9080303@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox