public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] UNS: [Nios2-dev] [PATCH] nios2: fix out of reach case for do_reset
Date: Mon, 16 Aug 2010 10:48:22 +0800	[thread overview]
Message-ID: <4C68A6F6.1000700@wytron.com.tw> (raw)
In-Reply-To: <4C65DA8F.5000301@heeltoe.com>

On 08/14/2010 07:51 AM, Brad Parker wrote:
> As a comment, that patch looks pretty ugly.  I might suggest an inline
> function (called "callr" or "nios2_callr") which
> encapsulates the __asm__.   That would make the code much easier to read.
>
> You could put the inline function in one of the asm headers.
>
> -brad

Hi Brad,

Thanks. I will add a macro for the inline asm.

- Thomas

  reply	other threads:[~2010-08-16  2:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13  2:40 [U-Boot] [PATCH] nios2: fix out of reach case for do_reset Thomas Chou
2010-08-13  2:52 ` Mike Frysinger
2010-08-13  3:26   ` Thomas Chou
2010-08-13 23:51 ` [U-Boot] UNS: [Nios2-dev] " Brad Parker
2010-08-16  2:48   ` Thomas Chou [this message]
2010-08-16  2:49   ` [U-Boot] [PATCH v2] " Thomas Chou
2010-08-20  2:25     ` Scott McNutt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C68A6F6.1000700@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox