From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Mon, 16 Aug 2010 10:48:22 +0800 Subject: [U-Boot] UNS: [Nios2-dev] [PATCH] nios2: fix out of reach case for do_reset In-Reply-To: <4C65DA8F.5000301@heeltoe.com> References: <1281667205-23282-1-git-send-email-thomas@wytron.com.tw> (sfid-20100812_224039_277713_FED0353C) <4C65DA8F.5000301@heeltoe.com> Message-ID: <4C68A6F6.1000700@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/14/2010 07:51 AM, Brad Parker wrote: > As a comment, that patch looks pretty ugly. I might suggest an inline > function (called "callr" or "nios2_callr") which > encapsulates the __asm__. That would make the code much easier to read. > > You could put the inline function in one of the asm headers. > > -brad Hi Brad, Thanks. I will add a macro for the inline asm. - Thomas