From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] CONFIG_RESET_PHY_R feature is broken
Date: Wed, 18 Aug 2010 03:16:19 +0400 [thread overview]
Message-ID: <4C6B1843.3080005@emcraft.com> (raw)
Hello Ben, Everybody,
some boards used to have their PHY quirks in board-specific reset_phy()
function. This used to work because of reset_phy() being called later
than Ethernet drivers initialization during startup.
But nowadays some drivers (in particular I faced this problem using
mpc5xxx_fec driver) use 'on demand' PHY initialization, and
board-specific quirks don't have effect any more... Actually,
CONFIG_RESET_PHY_R is broken even without 'on demand' PHY
initialization: at least mpc5xxx_fec driver can decide to reinit PHY
during normal operation and board-specific reset_phy() function won't be
called in this case too... Another design flaw of the CONFIG_RESET_PHY_R
feature is that boards with more than one Ethernet controller are pretty
common today and usually we want to initialize only the PHY connected to
the controller we are trying to use at the moment and there is no way to
tell the reset_phy() function which PHY we want to reset...
Ben, do you have any ideas how we could fix this?
I believe on of possible solutions here would be to introduce generic
PHY layer in U-Boot but unfortunately this would be too much efforts for
us in this project... Maybe somebody is aware of such work being done so
we can join?
Regards, Ilya.
next reply other threads:[~2010-08-17 23:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 23:16 Ilya Yanok [this message]
2010-08-18 7:02 ` [U-Boot] [RFC] CONFIG_RESET_PHY_R feature is broken Albert ARIBAUD
2010-08-18 7:52 ` Wolfgang Denk
2010-08-18 8:47 ` Ilya Yanok
2010-08-18 10:30 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6B1843.3080005@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox