public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pete Murray <pmurray@dawning.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] NAND 16 bit buswidth issue
Date: Thu, 19 Aug 2010 16:22:40 -0400	[thread overview]
Message-ID: <4C6D9290.5070007@dawning.com> (raw)
In-Reply-To: <20100819142723.38a40d8c@schlenkerla.am.freescale.net>

    The controller driver being used is ndfc.c, it doesn't set the 
options though.  From what I can tell, nand.c calls nand_scan without 
actually setting the nand options.  I have been setting chip->options to 
include NAND_BUSWIDTH_16, but want to move all my changes back to board 
specific code to eventually submit for review.  



 /* Lookup the flash id */
        for (i = 0; nand_flash_ids[i].name != NULL; i++) {
                if (dev_id == nand_flash_ids[i].id) {
                        type =  &nand_flash_ids[i];
                        break;
                }
        }

        if (!type)
                return ERR_PTR(-ENODEV);

        if (!mtd->name)
                mtd->name = type->name;

        chip->chipsize = type->chipsize << 20;
        
   
 Since type is set to the options read from nand_flash_ids in the 
nand_get_flash_type function, would it be appropriate to just set 
chip->options to type->options as is done with the chipsize?  If not, 
what would be the most acceptable way to do this?


       

  reply	other threads:[~2010-08-19 20:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 13:07 [U-Boot] NAND 16 bit buswidth issue Pete Murray
2010-08-19 19:27 ` Scott Wood
2010-08-19 20:22   ` Pete Murray [this message]
2010-08-19 20:46     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6D9290.5070007@dawning.com \
    --to=pmurray@dawning.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox