public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Align linebuf to avoid misaligned aliases of it
Date: Fri, 20 Aug 2010 08:48:51 +0200	[thread overview]
Message-ID: <4C6E2553.8000001@free.fr> (raw)
In-Reply-To: <201008190159.00585.vapier@gentoo.org>

Le 19/08/2010 07:58, Mike Frysinger a ?crit :
> On Wednesday, August 18, 2010 16:36:39 Albert ARIBAUD wrote:
>> Le 18/08/2010 19:54, Mike Frysinger a ?crit :
>>> On Wed, Aug 18, 2010 at 1:46 PM, Albert ARIBAUD wrote:
>>>> Le 18/08/2010 18:46, Mike Frysinger a ?crit :
>>>>> you need to include linux/compiler.h first ... but i would have
>>>>> thought this be a header already included globally.  maybe that's a
>>>>> new topic to start.
>>>>
>>>> I don't understand why I should introduce a dependency on linux. What is
>>>> the benefit?
>>>
>>> u-boot already includes the header in the source tree, not to mention
>>> the fact that this file is already including linux/ctype.h
>>
>> But absolutely no .h or .c file uses __aligned whereas
>> __attribute__((__aligned__())) is used in several places, right?
>
> that would seem to be the case currently
> -mike

In that case, I'll stick with the currently used syntax for this patch.

If someone feels the need to switch over to __aligned, I think issuing a 
separate global patch which changes all occurrences makes more sense 
than using both forms in the source code.

Amicalement,
-- 
Albert.

      reply	other threads:[~2010-08-20  6:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14  8:11 [U-Boot] [PATCH] Align linebuf to avoid misaligned aliases of it Albert Aribaud
2010-08-14  8:25 ` Mike Frysinger
2010-08-14  8:33   ` Albert ARIBAUD
2010-08-14 17:42     ` Mike Frysinger
2010-08-18 12:49       ` Albert ARIBAUD
2010-08-18 16:46         ` Mike Frysinger
2010-08-18 17:46           ` Albert ARIBAUD
2010-08-18 17:54             ` Mike Frysinger
2010-08-18 20:36               ` Albert ARIBAUD
2010-08-19  5:58                 ` Mike Frysinger
2010-08-20  6:48                   ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6E2553.8000001@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox