[U-Boot] [PATCH 1/4] MX51: iomux: Added support for mxc_iomux_set_input()

[Stefano Babic <sbabic@denx.de>]

David Jander wrote:
> Signed-off-by: David Jander <david@protonic.nl>
> ---

Hi Dave,

>  arch/arm/cpu/armv7/mx51/iomux.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 

Probably iut is better you set a more useful comment in your commit.
Instead of "Added support for	mxc_iomux_set_input()", you can explain
which is the new feature you provide. Something to explain you add a
utility for the "daisy chain" pins, to control the input path to a
module when the module can be connected to more as one pin.

The patch is part of a series. However, I can see only the first two
patches. Is there something missing ? I do not see any relation between
these two patches, too.

> +void mxc_iomux_set_input(iomux_input_select_t input, u32 config)
> +{
> +	u32 pad_reg = IOMUXSW_INPUT_CTL+(input*4);

Code styling, you should add spaces:

	u32 pad_reg = IOMUXSW_INPUT_CTL + (input * 4);

> +	writel(config, pad_reg);
> +}

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================