From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Fri, 20 Aug 2010 12:01:00 +0200
Subject: [U-Boot] [PATCH] Use common function to set GPIOs for MX3 and
 MX5
In-Reply-To: <201008201129.25980.david.jander@protonic.nl>
References: <1282292411-6087-1-git-send-email-sbabic@denx.de>
	<201008201129.25980.david.jander@protonic.nl>
Message-ID: <4C6E525C.3090205@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

David Jander wrote:
> Hi Stefano,
> 
Hi David,

> After this change, it seems something else is missing:
> GCC somehow removed the following code for i.MX51 without actually compiling 
> the arguments to the functions (???), but now it becomes evident this only 
> compiles for i.MX31:

Understood, in SPI driver. Really I had another patch in my private
tree, but I have not yet sent. However, as you note, it makes no sense
to split changes in two patches.

I will rebase my tree and send V2 version of the pacth, inclusive the
changes for mxc_spi.c

> void spi_cs_activate(struct spi_slave *slave)
> {
> 	struct mxc_spi_slave *mxcs = to_mxc_spi_slave(slave);
> 	if (mxcs->gpio > 0)
> 		mxc_gpio_set(mxcs->gpio, mxcs->ctrl_reg & MXC_CSPICTRL_SSPOL);

I know, I had already change this code...I store ss_pol in the priivate
structure to be independent from the processor register.

I will send the compound patch soon.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================