From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 20 Aug 2010 12:20:25 +0200 Subject: [U-Boot] [PATCH] Use common function to set GPIOs for MX3 and MX5 In-Reply-To: <201008201207.44578.david.jander@protonic.nl> References: <1282292411-6087-1-git-send-email-sbabic@denx.de> <201008201129.25980.david.jander@protonic.nl> <4C6E525C.3090205@denx.de> <201008201207.44578.david.jander@protonic.nl> Message-ID: <4C6E56E9.1050807@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de David Jander wrote: > Great. I'll wait. > In the meantime I have just done this to get it working: > > #ifdef CONFIG_MX31 > void spi_cs_activate(struct spi_slave *slave) > { > struct mxc_spi_slave *mxcs = to_mxc_spi_slave(slave); > if (mxcs->gpio > 0) > mxc_gpio_set(mxcs->gpio, mxcs->ctrl_reg & MXC_CSPICTRL_SSPOL); > } > Ok, but one goal I have is to get rid of nasty #ifdef CONFIG_MX*. I introduce general gpio functions to make code more common, and I do not want to fall back adding processor switches. > Seems to work, but never mind... Ok, I will resend my patch, I hope you can give a chance a test it on your target. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================