From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode
Date: Tue, 24 Aug 2010 12:53:49 +0200 [thread overview]
Message-ID: <4C73A4BD.506@emk-elektronik.de> (raw)
In-Reply-To: <AANLkTikD_=B7js1PadzVWiFHAb92_7Nti2L1h9kYEKC2@mail.gmail.com>
Dear Mike Frysinger,
> this usage string no longer makes sense. how about:
> "[<bus>:]<cs>[.<mode>] <bit_len> <dout> - Send <bit_len> bits from
> <dout> out the SPI\n"
The problem is, that without blowing up the parser even more, only
2 forms of the command are valid:
the classic form
<cs> <bit_len> <dout>
or
<bus>:<cs>[.<mode>] <bit_len> <dout>
Since this command is mainly used for testing/debugging hardware,
I saw no need to allow the form
<cs>.<mode> <bit_len> <dout>
If thats ok, I can make a patch with the help fixed.
Best Regards
Reinhard
next prev parent reply other threads:[~2010-08-24 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 16:21 [U-Boot] [PATCH] SPI: cmd_spi.c: add option to specify bus and mode Reinhard Meyer
2010-08-09 17:05 ` Mike Frysinger
2010-08-23 22:15 ` Mike Frysinger
2010-08-24 8:05 ` Reinhard Meyer
2010-08-24 21:07 ` Mike Frysinger
2010-08-24 10:53 ` Reinhard Meyer [this message]
2010-08-26 2:04 ` Mike Frysinger
2010-08-26 5:26 ` Reinhard Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C73A4BD.506@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox