From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Fri, 27 Aug 2010 07:25:01 +0200
Subject: [U-Boot] [PATCH 1/2] I2C: add Marvell TWSI simple driver
In-Reply-To: <4C76E4A8.8020100@free.fr>
References: <1282746213-4318-1-git-send-email-albert.aribaud@free.fr>
	<4C7609F3.7020509@invitel.hu> <4C76E4A8.8020100@free.fr>
Message-ID: <4C774C2D.4090100@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Albert,

Albert ARIBAUD wrote:
> Le 26/08/2010 08:30, Heiko Schocher a ?crit :
> 
>> Beside of that, I have just some minor codstyling comments:
> 
> Meanwhile, I've run checkpatch on this file and fixed every warning and
> error, thus some of your comments were taken care of in the process.
> That left:
> 
>>> +#define    MVTWSI_STATUS_DATA_R_NAK    0x58 /* our NAK, not the
>>> slave's */
>>
>> line too long.
> 
> Checkpatch did not complain on this one. Is there a specific line length
> contraint beside passing checkpatch?

Yep, 78 characters.

>>> +/*
>>> + * Wait for IFLG to raise, or return 'timeout'; then if status is as
>>> expected,
>>> + * return 0 (ok) or return 'wrong status'.
>>> + */
>>> +
>>
>> blank line not necessary.
> 
> Which blank line exactly? Between the comment block and code? If so,

Yes.

> does this apply everywhere, i.e. after the topmost license comment
> block, before blocks of #define, etc?

No, there, it is Ok.

> As a side note, if V2 gets Acked by Prafulla and you, can you add the
> commit to your i2c tree and ask for a new pull? Anyway, Wolfgang said he
> won't resume activity on u-boot before sep 5th.

Yes, if I and Prafulla accept it, this is the usual way.

bye,
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany