From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 3/4] i2c: rewrite mvtwsi, support orion5x and kirkwood
Date: Fri, 27 Aug 2010 07:32:53 +0200 [thread overview]
Message-ID: <4C774E05.4010603@denx.de> (raw)
In-Reply-To: <1282870532-2727-4-git-send-email-albert.aribaud@free.fr>
Hello Albert,
Albert Aribaud wrote:
> This rewrite of the mvtwsi driver is 25% smaller and much
> faster and simpler than the previous code.
>
> Signed-off-by: Albert Aribaud <albert.aribaud@free.fr>
> ---
> drivers/i2c/mvtwsi.c | 748 +++++++++++++++++++++++---------------------------
> 1 files changed, 341 insertions(+), 407 deletions(-)
looks OK to me, but can you delete the blank line between
a function comment and the code itself? Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2010-08-27 5:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 0:55 [U-Boot] [PATCH V2 0/4] Improve I2C for orion5x, kirkwood and ED Mini V2 Albert Aribaud
2010-08-27 0:55 ` [U-Boot] [PATCH V2 1/4] suen3: remove CONFIG_HARD_I2C and related defines Albert Aribaud
2010-08-27 0:55 ` [U-Boot] [PATCH V2 2/4] i2c: rename kirkwood_i2c to mvtwsi Albert Aribaud
2010-08-27 0:55 ` [U-Boot] [PATCH V2 3/4] i2c: rewrite mvtwsi, support orion5x and kirkwood Albert Aribaud
2010-08-27 5:32 ` Heiko Schocher [this message]
2010-08-27 0:55 ` [U-Boot] [PATCH V2 4/4] edminiv2: add I2C support using mvtwsi driver Albert Aribaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C774E05.4010603@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox