From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 27 Aug 2010 07:32:53 +0200 Subject: [U-Boot] [PATCH V2 3/4] i2c: rewrite mvtwsi, support orion5x and kirkwood In-Reply-To: <1282870532-2727-4-git-send-email-albert.aribaud@free.fr> References: <1282870532-2727-1-git-send-email-albert.aribaud@free.fr> <1282870532-2727-4-git-send-email-albert.aribaud@free.fr> Message-ID: <4C774E05.4010603@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Albert, Albert Aribaud wrote: > This rewrite of the mvtwsi driver is 25% smaller and much > faster and simpler than the previous code. > > Signed-off-by: Albert Aribaud > --- > drivers/i2c/mvtwsi.c | 748 +++++++++++++++++++++++--------------------------- > 1 files changed, 341 insertions(+), 407 deletions(-) looks OK to me, but can you delete the blank line between a function comment and the code itself? Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany