From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Orion5x: bugfix: window size (mis)calculation
Date: Fri, 27 Aug 2010 07:37:05 +0200 [thread overview]
Message-ID: <4C774F01.3020703@free.fr> (raw)
In-Reply-To: <4C774652.6090200@free.fr>
Le 27/08/2010 07:00, Chris Moore a ?crit :
> Hi list,
Hi Chris!
> [...]
> For range 0x00000000 to 0x00000000 Chris Moore's fast
> orion5x_winctrl_calcsize returns 0xffff
> [...]
> For range 0x80000001 to 0xffffffff Chris Moore's fast
> orion5x_winctrl_calcsize returns 0xffff
>
> AIUI (apart from the question of how best to handle a size of 0) this is
> the required result.
I think your proposal to handle size 0 as meaning '4 MB' is fine, since
there is no way to express 4MB and a zero size is meaningless as such.
> If I have misunderstood, please tell me and I'll rewrite.
That's fine. Do you want me to resubmit a V2 patch with your change, or
will you subit it yourself?
> HTH.
It does, as does every fix that brings orion/kirkwood U-boot nearer to
industry strength. :)
> Cheers,
> Chris
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-08-27 5:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 13:27 [U-Boot] [PATCH] Orion5x: bugfix: window size (mis)calculation Albert Aribaud
2010-08-26 4:55 ` Prafulla Wadaskar
2010-08-27 5:00 ` Chris Moore
2010-08-27 5:37 ` Albert ARIBAUD [this message]
2010-08-27 5:41 ` Albert ARIBAUD
2010-08-28 5:32 ` Chris Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C774F01.3020703@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox