[U-Boot] [PATCH V3 3/4] i2c: rewrite mvtwsi, support orion5x and kirkwood

Prafulla Wadaskar
2010-08-27T14:30:34Z

> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.aribaud at free.fr]
> Sent: Friday, August 27, 2010 6:33 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH V3 3/4] i2c: rewrite mvtwsi,
> support orion5x and kirkwood
>
> Le 27/08/2010 14:34, Prafulla Wadaskar a ?crit :
> >
> >
> >> -----Original Message-----
> >> From: u-boot-bounces at lists.denx.de
> >> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> >> Sent: Friday, August 27, 2010 11:42 AM
> >> To: u-boot at lists.denx.de
> >> Subject: [U-Boot] [PATCH V3 3/4] i2c: rewrite mvtwsi, support
> >> orion5x and kirkwood
> >>
> >> This rewrite of the mvtwsi driver is 25% smaller and much
> >> faster and simpler than the previous code.
> >>
> >> Signed-off-by: Albert Aribaud<albert.aribaud@free.fr>
> >> ---
> >> drivers/i2c/mvtwsi.c | 742
> >> +++++++++++++++++++++++---------------------------
> >> 1 files changed, 334 insertions(+), 408 deletions(-)
> >>
> >> diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c
> >> index a4409be..e7f08ac 100644
> >> --- a/drivers/i2c/mvtwsi.c
> >> +++ b/drivers/i2c/mvtwsi.c
> >> @@ -1,10 +1,7 @@
> >> /*
> >> - * Driver for the i2c controller on the Marvell line of
> host bridges
> >> - * (e.g, gt642[46]0, mv643[46]0, mv644[46]0, Orion SoC family),
> >> - * and Kirkwood family.
> >> + * Driver for the TWSI (i2c) controller on the Marvell orion5x
> >
> > Don't you think Kirkwood is missing here ?
Hi Albert
Any commetns for this?

Regards..
Prafulla . .

> >
> >> *
> >> - * Based on:
> >> - * Author: Mark A. Greer<mgreer@mvista.com>
> >> + * Author: Albert Aribaud<albert.aribaud@free.fr>
> >> * 2005 (c) MontaVista, Software, Inc.
> >
> > I hope this line is not there in earlier version, pls confirm..
>
> The Montavista (c) line is in the kirkwood_i2c file from which I
> copy-pasted the GPL notice. I'd even posted a remark myself
> on V1 of the
> patch, stating that this copyright line was a leftover of the old
> driver, and that I would fix it on V2. Somehow I missed it.
>
> Amicalement,
> --
> Albert.
>