From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiangfu Liu Date: Mon, 30 Aug 2010 20:32:26 +0800 Subject: [U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits In-Reply-To: <4C7B911B.9040706@emk-elektronik.de> References: <1283162342-23558-1-git-send-email-xiangfu@openmobilefree.net> <4C7B911B.9040706@emk-elektronik.de> Message-ID: <4C7BA4DA.1020005@openmobilefree.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Reinhard thanks for reply. On 08/30/2010 07:08 PM, Reinhard Meyer wrote: > Xiangfu Liu schrieb: >> Signed-off-by: Xiangfu Liu >> --- >> include/mmc.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/mmc.h b/include/mmc.h >> index fcb237e..b913a60 100644 >> --- a/include/mmc.h >> +++ b/include/mmc.h >> @@ -189,12 +189,12 @@ struct mmc_csd >> u8 tran_speed; >> u16 ccc:12, >> read_bl_len:4; >> + u32 c_size:22; >> u64 read_bl_partial:1, >> write_blk_misalign:1, >> read_blk_misalign:1, >> dsr_imp:1, >> rsvd2:2, >> - c_size:12, >> vdd_r_curr_min:3, >> vdd_r_curr_max:3, >> vdd_w_curr_min:3, > > NAK > > This structure approach is awfully broken. LE/BE > issues, c_size spans over a 32 bit boundary! > > The generic MMC works fine with no such structure. > > I already proposed in earlier patches to finally > remove that structure. > > Reinhard > - -- Best Regards Xiangfu Liu http://www.openmobilefree.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkx7pNoACgkQRRAEFRxkgLRivQCglcRpN3tjUs2ptn3l4e6+JvW0 gV0Aniqr8mgjF3DjR+M70a66DSvte4ew =xfDj -----END PGP SIGNATURE-----