* [U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits
@ 2010-08-30 9:59 Xiangfu Liu
2010-08-30 11:08 ` Reinhard Meyer
0 siblings, 1 reply; 3+ messages in thread
From: Xiangfu Liu @ 2010-08-30 9:59 UTC (permalink / raw)
To: u-boot
Signed-off-by: Xiangfu Liu <xiangfu@openmobilefree.net>
---
include/mmc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/mmc.h b/include/mmc.h
index fcb237e..b913a60 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -189,12 +189,12 @@ struct mmc_csd
u8 tran_speed;
u16 ccc:12,
read_bl_len:4;
+ u32 c_size:22;
u64 read_bl_partial:1,
write_blk_misalign:1,
read_blk_misalign:1,
dsr_imp:1,
rsvd2:2,
- c_size:12,
vdd_r_curr_min:3,
vdd_r_curr_max:3,
vdd_w_curr_min:3,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits
2010-08-30 9:59 [U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits Xiangfu Liu
@ 2010-08-30 11:08 ` Reinhard Meyer
2010-08-30 12:32 ` Xiangfu Liu
0 siblings, 1 reply; 3+ messages in thread
From: Reinhard Meyer @ 2010-08-30 11:08 UTC (permalink / raw)
To: u-boot
Xiangfu Liu schrieb:
> Signed-off-by: Xiangfu Liu <xiangfu@openmobilefree.net>
> ---
> include/mmc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/mmc.h b/include/mmc.h
> index fcb237e..b913a60 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -189,12 +189,12 @@ struct mmc_csd
> u8 tran_speed;
> u16 ccc:12,
> read_bl_len:4;
> + u32 c_size:22;
> u64 read_bl_partial:1,
> write_blk_misalign:1,
> read_blk_misalign:1,
> dsr_imp:1,
> rsvd2:2,
> - c_size:12,
> vdd_r_curr_min:3,
> vdd_r_curr_max:3,
> vdd_w_curr_min:3,
NAK
This structure approach is awfully broken. LE/BE
issues, c_size spans over a 32 bit boundary!
The generic MMC works fine with no such structure.
I already proposed in earlier patches to finally
remove that structure.
Reinhard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits
2010-08-30 11:08 ` Reinhard Meyer
@ 2010-08-30 12:32 ` Xiangfu Liu
0 siblings, 0 replies; 3+ messages in thread
From: Xiangfu Liu @ 2010-08-30 12:32 UTC (permalink / raw)
To: u-boot
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Reinhard
thanks for reply.
On 08/30/2010 07:08 PM, Reinhard Meyer wrote:
> Xiangfu Liu schrieb:
>> Signed-off-by: Xiangfu Liu <xiangfu@openmobilefree.net>
>> ---
>> include/mmc.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/mmc.h b/include/mmc.h
>> index fcb237e..b913a60 100644
>> --- a/include/mmc.h
>> +++ b/include/mmc.h
>> @@ -189,12 +189,12 @@ struct mmc_csd
>> u8 tran_speed;
>> u16 ccc:12,
>> read_bl_len:4;
>> + u32 c_size:22;
>> u64 read_bl_partial:1,
>> write_blk_misalign:1,
>> read_blk_misalign:1,
>> dsr_imp:1,
>> rsvd2:2,
>> - c_size:12,
>> vdd_r_curr_min:3,
>> vdd_r_curr_max:3,
>> vdd_w_curr_min:3,
>
> NAK
>
> This structure approach is awfully broken. LE/BE
> issues, c_size spans over a 32 bit boundary!
>
> The generic MMC works fine with no such structure.
>
> I already proposed in earlier patches to finally
> remove that structure.
>
> Reinhard
>
- --
Best Regards
Xiangfu Liu
http://www.openmobilefree.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkx7pNoACgkQRRAEFRxkgLRivQCglcRpN3tjUs2ptn3l4e6+JvW0
gV0Aniqr8mgjF3DjR+M70a66DSvte4ew
=xfDj
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-30 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 9:59 [U-Boot] [PATCH] fix the c_size, in CSD Version 2.0, it's 22 bits Xiangfu Liu
2010-08-30 11:08 ` Reinhard Meyer
2010-08-30 12:32 ` Xiangfu Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox