From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] IDE: Don't assume there are always two devices per bus
Date: Sat, 04 Sep 2010 11:07:44 +0200 [thread overview]
Message-ID: <4C820C60.7010102@free.fr> (raw)
In-Reply-To: <4C8201CB.9080606@free.fr>
Le 04/09/2010 10:22, Albert ARIBAUD a ?crit :
> Le 26/08/2010 15:16, Rogan Dawes a ?crit :
>
>> Anything wrong with this patch?
>
> I think I finally found what was bugging me with it.
>
> Granted, there are cases where we don't want two devices per bus, but
> this is a requirement unrelated to the maximum number of busses and
> devices: this is simply due to the fact that we're on a SATA, not PATA,
> controller.
>
> I think that, rather than modifying IDE_BUS(dev), you should introduce a
> CONFIG_SYS_IDE_MAXDEVICE_PER_BUS config option that will limit how many
> devices will be probed for on a given bus.
>
> Without this config option, for each bus B there can be up to two
> devices, numbered (B*2) and (B*2+1); with the config option, there can
> be only one device numbered (B*2). In all cases, IDE_BUS(dev) can remain
> defined as (dev>> 1) which will always amount to B.
>
> Amicalement,
Rogan,
Actually, I am looking into refactoring the cmd_ide.c code right now,
because I'll need it for supporting the net5big's eight ports and
devices. Do you mind if I give a try at my own suggestion?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-09-04 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-14 10:41 [U-Boot] IDE_BUS unconditionally expects 2 devices per bus Rogan Dawes
2010-08-14 10:46 ` Rogan Dawes
2010-08-14 11:45 ` Albert ARIBAUD
2010-08-15 20:35 ` [U-Boot] [PATCH] IDE: Don't assume there are always two " Rogan Dawes
2010-08-15 21:30 ` Wolfgang Denk
2010-08-16 5:47 ` [U-Boot] [PATCH v2] " Rogan Dawes
2010-08-16 5:47 ` [U-Boot] [PATCH] " Rogan Dawes
2010-08-26 13:16 ` Rogan Dawes
2010-09-04 8:22 ` Albert ARIBAUD
2010-09-04 9:07 ` Albert ARIBAUD [this message]
2010-09-05 21:23 ` Rogan Dawes
2010-09-05 22:19 ` Wolfgang Denk
2010-09-06 5:54 ` Albert ARIBAUD
2010-09-06 6:03 ` Rogan Dawes
2010-09-06 6:05 ` Wolfgang Denk
2010-09-06 6:45 ` Albert ARIBAUD
2010-09-06 8:18 ` Wolfgang Denk
2010-09-06 11:32 ` Albert ARIBAUD
2010-09-06 12:50 ` Wolfgang Denk
2010-09-06 17:15 ` Albert ARIBAUD
2010-09-06 19:35 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C820C60.7010102@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox