From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence
Date: Sun, 05 Sep 2010 21:33:52 +0200 [thread overview]
Message-ID: <4C83F0A0.80701@free.fr> (raw)
In-Reply-To: <4C8376ED.3060408@mvista.com>
Hi Sergei,
Le 05/09/2010 12:54, Sergei Shtylyov a ?crit :
>> + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */
>> control = readl(&port->scontrol);
>> control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT;
>> + /* Toggle control DET back to 0 (normal operation) */
>
> But you haven't set it to 1 yet. Maybe the comment is misplaced?
Look at the comment above, which said DET was set to 1, and at
MVSATA_PORT_INIT, which combines IPM=3 and DET=1.
>> + return (tout? 0: 1);
>
> Why not !tout? (And you forgot a space before colon. :-)
Why not indeed? I'll fix this in the next version.
> WBR, Sergei
Thanks!
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-09-05 19:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 10:34 [U-Boot] [PATCH] mvsata_ide: adjust port init sequence Albert Aribaud
2010-09-05 10:54 ` Sergei Shtylyov
2010-09-05 19:33 ` Albert ARIBAUD [this message]
2010-09-06 9:18 ` Sergei Shtylyov
2010-09-06 10:27 ` Albert ARIBAUD
2010-09-06 12:45 ` Sergei Shtylyov
2010-09-06 15:47 ` Albert ARIBAUD
-- strict thread matches above, loose matches on Subject: below --
2010-09-06 22:53 Albert Aribaud
2010-09-06 23:02 ` Albert ARIBAUD
2010-09-07 9:34 ` Wolfgang Denk
2010-09-07 9:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C83F0A0.80701@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox