From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Sun, 05 Sep 2010 21:33:52 +0200
Subject: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence
In-Reply-To: <4C8376ED.3060408@mvista.com>
References: <1283596440-3856-1-git-send-email-albert.aribaud@free.fr>
	<4C8376ED.3060408@mvista.com>
Message-ID: <4C83F0A0.80701@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Sergei,

Le 05/09/2010 12:54, Sergei Shtylyov a ?crit :

>> + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */
>> control = readl(&port->scontrol);
>> control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT;
>> + /* Toggle control DET back to 0 (normal operation) */
>
> But you haven't set it to 1 yet. Maybe the comment is misplaced?

Look at the comment above, which said DET was set to 1, and at 
MVSATA_PORT_INIT, which combines IPM=3 and DET=1.

>> + return (tout? 0: 1);
>
> Why not !tout? (And you forgot a space before colon. :-)

Why not indeed? I'll fix this in the next version.

> WBR, Sergei

Thanks!

Amicalement,
-- 
Albert.