From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Mon, 06 Sep 2010 17:47:07 +0200
Subject: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence
In-Reply-To: <4C84E281.1000105@mvista.com>
References: <1283596440-3856-1-git-send-email-albert.aribaud@free.fr>
	<4C8376ED.3060408@mvista.com> <4C83F0A0.80701@free.fr>
	<4C84B202.70901@mvista.com> <4C84C20E.3020006@free.fr>
	<4C84E281.1000105@mvista.com>
Message-ID: <4C850CFB.5030308@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 06/09/2010 14:45, Sergei Shtylyov a ?crit :
> Hello.
>
> Albert ARIBAUD wrote:
>
>>> On 05.09.2010 23:33, Albert ARIBAUD wrote:
>
>>>>>> + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */
>>>>>> control = readl(&port->scontrol);
>>>>>> control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT;
>>>>>> + /* Toggle control DET back to 0 (normal operation) */
>
>>>>> But you haven't set it to 1 yet. Maybe the comment is misplaced?
>
>>>> Look at the comment above, which said DET was set to 1, and at
>>>> MVSATA_PORT_INIT, which combines IPM=3 and DET=1.
>
>>> But you didn't write that value yet before your comment saying that
>>> you're resetting DET back to 0.
>
>> Yes, I did:
>
>> #define MVSATA_PORT_INIT \
>> (MVSATA_SCONTROL_DET_INIT|MVSATA_SCONTROL_IPM_NO_LP_ALLOWED)
>
>> MVSATA_PORT_INIT has both IPM = 3 (no low power allowed) and DET = 1
>> (initialize).
>
> Sigh. Your "resetting DET" comment is before the first writel().
>
>> Amicalement,
>
> WBR, Sergei

Oh, I see! I'll push a new version with the comment moved down one 
notch. Thanks for your patience. :)

Amicalement,
-- 
Albert.