From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence
Date: Tue, 07 Sep 2010 13:23:26 +0200 [thread overview]
Message-ID: <4C8620AE.2000605@free.fr> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19A68797C1@SC-VEXCH4.marvell.com>
Le 07/09/2010 08:42, Prafulla Wadaskar a ?crit :
>> diff --git a/drivers/block/mvsata_ide.c b/drivers/block/mvsata_ide.c
>> @@ -125,15 +129,17 @@ int ide_preinit(void)
>> + return 1;
>
> How about returning negative values for errors ?
Function ide_preinit() is called from cmd_ide.c:ide_init(), which does
not distinguish positive vs negative return values, ony zero vs
non-zero. So what would be the point of returning negative rather than
positive values?
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-09-07 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 23:02 [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence Albert Aribaud
2010-09-07 6:42 ` Prafulla Wadaskar
2010-09-07 11:23 ` Albert ARIBAUD [this message]
2010-09-07 13:32 ` Prafulla Wadaskar
2010-09-07 14:06 ` Wolfgang Denk
2010-09-07 17:32 ` Albert ARIBAUD
2010-09-07 19:00 ` Wolfgang Denk
2010-09-07 21:14 ` Albert ARIBAUD
2010-09-07 9:23 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8620AE.2000605@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox