From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Tue, 07 Sep 2010 13:23:26 +0200
Subject: [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19A68797C1@SC-VEXCH4.marvell.com>
References: <1283814151-8440-1-git-send-email-albert.aribaud@free.fr>
	<F766E4F80769BD478052FB6533FA745D19A68797C1@SC-VEXCH4.marvell.com>
Message-ID: <4C8620AE.2000605@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 07/09/2010 08:42, Prafulla Wadaskar a ?crit :
>> diff --git a/drivers/block/mvsata_ide.c b/drivers/block/mvsata_ide.c

>> @@ -125,15 +129,17 @@ int ide_preinit(void)

>> +		return 1;
>
> How about returning negative values for errors ?

Function ide_preinit() is called from cmd_ide.c:ide_init(), which does 
not distinguish positive vs negative return values, ony zero vs 
non-zero. So what would be the point of returning negative rather than 
positive values?

Amicalement,
-- 
Albert.