From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 07 Sep 2010 19:32:49 +0200 Subject: [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence In-Reply-To: <20100907140630.4E2A8B715F@gemini.denx.de> References: <1283814151-8440-1-git-send-email-albert.aribaud@free.fr> <4C8620AE.2000605@free.fr> <20100907140630.4E2A8B715F@gemini.denx.de> Message-ID: <4C867741.6060906@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 07/09/2010 16:06, Wolfgang Denk a ?crit : >> Negative always represents errors, >> whereas positive may represent some valid return state. > > He. This is _not_quite_ correct. Not in U-Boot, and not in genreal. > > [But your comment asking for a negative return code is valid, of > course.] I'm a bit lost at the logic of this last sentence. If errors are not always represented as negative return values, and especially so in U-boot, then what is the rationale for supporting a request for specifically negative error return values, rather than positive, here? Not that I mind much -- as I said, ide_init() does not mind, and that's my reference -- and I'll happily put negative error codes in V3, but I like to understand why people want things. Amicalement, -- Albert.