[U-Boot] [PATCH] da850evm: basic MII EMAC support

Ben Gardiner
2010-09-13T12:55:47Z

Hi Mike,

On Sat, Sep 11, 2010 at 12:01 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday, September 10, 2010 16:10:16 Ben Gardiner wrote:
>> The current da850evm support in u-boot/master [1] omits any use of
>> the davinci EMAC. This patch adds basic support for the EMAC using
>> the MII PHY found on the baseboard of the EVM. The MAC address is
>> read from the environment variable 'ethadd'. Note that this is
>> different from the da850evm support in the u-boot omapl1 tree
>> where the MAC address is read from SPI flash [2].
>>
>> CC: Sandeep Paulraj <s-paulraj@ti.com>
>> CC: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
>
> where is your sign-off-by ? ?patches cant be merged without it.

Right. My mistake, sorry.

>> [1] http://git.denx.de/?p=u-boot.git
>> [2] http://arago-project.org/git/projects/?p=u-boot-omapl1.git
>
> these URLs are useless. ?just drop them.

Thanks for the feedback on these -- I have been wondering whether URL
footnotes were desirable in commit messages. I put them there since I
can remember that it is sometimes difficult to find the trees that are
being referred to when you are a newcomer. Would SHA1's and/or git
URLs be more acceptable? Or is the point that nothing before the '---'
should have links?

Best Regards,
Ben Gardiner

---
Nanometrics Inc.