[U-Boot] [PATCH] da850evm: basic MII EMAC support

Mike Frysinger
2010-09-14T13:00:15Z

On Monday, September 13, 2010 08:55:47 Ben Gardiner wrote:
> On Sat, Sep 11, 2010 at 12:01 AM, Mike Frysinger wrote:
> > On Friday, September 10, 2010 16:10:16 Ben Gardiner wrote:
> >> The current da850evm support in u-boot/master [1] omits any use of
> >> the davinci EMAC. This patch adds basic support for the EMAC using
> >> the MII PHY found on the baseboard of the EVM. The MAC address is
> >> read from the environment variable 'ethadd'. Note that this is
> >> different from the da850evm support in the u-boot omapl1 tree
> >> where the MAC address is read from SPI flash [2].
> >>
> >> [1] http://git.denx.de/?p=u-boot.git
> >> [2] http://arago-project.org/git/projects/?p=u-boot-omapl1.git
> >
> > these URLs are useless. just drop them.
>
> Thanks for the feedback on these -- I have been wondering whether URL
> footnotes were desirable in commit messages. I put them there since I
> can remember that it is sometimes difficult to find the trees that are
> being referred to when you are a newcomer. Would SHA1's and/or git
> URLs be more acceptable? Or is the point that nothing before the '---'
> should have links?

it depends on the URLs. i dont think referring to the mainline git tree is
useful at all considering that's what they're using if they have this patch in
their tree. as for the omap1 reference, i'm not sure mentioning at all is
useful in the commit. presumably the tree in question will drop its code and
move to the mainline stuff one yours is merged. imo, that would make it a
"note" which goes below the "---".

if the URL is generally useful, then some people use a dedicated tag in the
"s-o-b" section such as "URL: xxx". this isnt exactly standardized.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/714c8fe8/attachment.pgp