public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: fix capacity calculation with high capacity mmc
Date: Sun, 19 Sep 2010 06:32:03 +0200	[thread overview]
Message-ID: <4C959243.9010004@emk-elektronik.de> (raw)
In-Reply-To: <20100918214947.C0939157D71@gemini.denx.de>

Dear Wolfgang Denk, Lei Wen, Andy Fleming,
> Dear Lei Wen,
>
> In message<AANLkTimaQtTCJf52DjF-AhdEfFQbHfwyeJD3024VwFWu@mail.gmail.com>  you wrote:
>>
>> How about merge this patch? :-)
>
> I will wait for a pull request from the responsible custodian.
>
> Maybe you should have put him on cc: ...  (done now).
@@ -441,6 +441,11 @@ int mmc_change_freq(struct mmc *mmc)
 >>>       if (!ext_csd[185])
 >>>               return 0;
 >>>
 >>> +     if (!IS_SD(mmc) && mmc->high_capacity) {
 >>> +             mmc->capacity = ext_csd[212] | (ext_csd[213] << 8)
 >>> +                     | (ext_csd[214] << 16) | (ext_csd[215] << 24);
 >>> +             mmc->capacity *= mmc->read_bl_len;
 >>> +     }
 >>>       /* High Speed is set, there are two types: 52MHz and 26MHz */
 >>>
I am still convinced "mmc_change_freq()" is the wrong place to do that
calculation. All other card types do it around line 700...

Best Regards,
Reinhard

  reply	other threads:[~2010-09-19  4:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06 13:59 [U-Boot] [PATCH] mmc: fix capacity calculation with high capacity mmc Lei Wen
2010-09-06 14:07 ` Reinhard Meyer
2010-09-06 14:11   ` Lei Wen
2010-09-13  4:04     ` Lei Wen
2010-09-18 21:49       ` Wolfgang Denk
2010-09-19  4:32         ` Reinhard Meyer [this message]
2010-09-19  8:27           ` Lei Wen
2010-09-21 14:45         ` John Rigby
2010-09-24 10:49           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C959243.9010004@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox