[U-Boot] [PATCH 12/26 v2][NEXT] ARM: add relocation support

Albert ARIBAUD
2010-09-19T08:28:12Z

Le 17/09/2010 13:10, Heiko Schocher a ?crit :

> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 54519b0..88c6427 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c

> +void board_init_f (ulong bootflag)

A recursive grep found 'bootflag' nowhere else in the whole u-boot code;
it always receives the value 0 from start.S; and is not used in
board_init_f. What was it supposed to be for?

(if it has no use, no need to remove it: I am preparing a patch which
will need to pass an argument from _start to board_init_f, and bootflag
should be alright).

> + relocate_code (addr_sp, id, addr);
> + /* NOTREACHED - relocate_code() does not return */
> +}

Why call relocate_code() here when board_init_f could simply return to
it? (passing a success/failure through a return value if necessary).

Amicalement,
--
Albert.