From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Sun, 19 Sep 2010 10:28:12 +0200
Subject: [U-Boot] [PATCH 12/26 v2][NEXT] ARM: add relocation support
In-Reply-To: <1284721853-8298-13-git-send-email-hs@denx.de>
References: <4C62E8C3.8050006@denx.de>	<1284721853-8298-1-git-send-email-hs@denx.de>	<1284721853-8298-2-git-send-email-hs@denx.de>	<1284721853-8298-3-git-send-email-hs@denx.de>	<1284721853-8298-4-git-send-email-hs@denx.de>	<1284721853-8298-5-git-send-email-hs@denx.de>	<1284721853-8298-6-git-send-email-hs@denx.de>	<1284721853-8298-7-git-send-email-hs@denx.de>	<1284721853-8298-8-git-send-email-hs@denx.de>	<1284721853-8298-9-git-send-email-hs@denx.de>	<1284721853-8298-10-git-send-email-hs@denx.de>	<1284721853-8298-11-git-send-email-hs@denx.de>	<1284721853-8298-12-git-send-email-hs@denx.de>
	<1284721853-8298-13-git-send-email-hs@denx.de>
Message-ID: <4C95C99C.7090309@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 17/09/2010 13:10, Heiko Schocher a ?crit :

> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 54519b0..88c6427 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c

> +void board_init_f (ulong bootflag)

A recursive grep found 'bootflag' nowhere else in the whole u-boot code; 
it always receives the value 0 from start.S; and is not used in 
board_init_f. What was it supposed to be for?

(if it has no use, no need to remove it: I am preparing a patch which 
will need to pass an argument from _start to board_init_f, and bootflag 
should be alright).

> +	relocate_code (addr_sp, id, addr);
> +	/* NOTREACHED - relocate_code() does not return */
> +}

Why call relocate_code() here when board_init_f could simply return to 
it? (passing a success/failure through a return value if necessary).

Amicalement,
-- 
Albert.