[U-Boot] [PATCH] p1022ds: add video support

Timur Tabi
2010-09-21T23:01:19Z

Anatolij Gustschin wrote:
>> Also, I thought it would be better to provide some sort of completeness for the
>> > bits I am using.
> We do not add unused code.

Well, I don't see how macros are "unused code", but I'll delete those lines.

>>> > > CONFIG_VIDEO definition should depend on CONFIG_FSL_DIU_FB,
>>> > > I think. Otherwise the building won't succeed if CONFIG_FSL_DIU_FB
>>> > > is not defined (due to absence of video_hw_init()).
>> >
>> > We need the DIU initialized, even if U-Boot doesn't use it. This is what
>> > CONFIG_FSL_DIU_FB does. CONFIG_VIDEO then tells U-Boot to actually use the DIU.

> I understand it. I didn't say you should make CONFIG_FSL_DIU_FB
> dependent on CONFIG_VIDEO, but the opposite.

Ok.

> On the other site, one of the design principles states:
>
> initialize devices only when they are needed within U-Boot.

Well, I'll try to work toward that, but I'm pretty sure there are plenty of
devices that are initialized but not used in U-Boot already.

--
Timur Tabi
Linux kernel developer at Freescale