[U-Boot] [PATCH] p1022ds: add video support

Detlev Zundel
2010-09-22T15:07:25Z

Hi Timur,

> Anatolij Gustschin wrote:
>>> Also, I thought it would be better to provide some sort of completeness for the
>>> > bits I am using.
>> We do not add unused code.
>
> Well, I don't see how macros are "unused code", but I'll delete those lines.
>
>>>> > > CONFIG_VIDEO definition should depend on CONFIG_FSL_DIU_FB,
>>>> > > I think. Otherwise the building won't succeed if CONFIG_FSL_DIU_FB
>>>> > > is not defined (due to absence of video_hw_init()).
>>> >
>>> > We need the DIU initialized, even if U-Boot doesn't use it. This is what
>>> > CONFIG_FSL_DIU_FB does. CONFIG_VIDEO then tells U-Boot to actually use the DIU.
>
>> I understand it. I didn't say you should make CONFIG_FSL_DIU_FB
>> dependent on CONFIG_VIDEO, but the opposite.
>
> Ok.
>
>> On the other site, one of the design principles states:
>>
>> initialize devices only when they are needed within U-Boot.
>
> Well, I'll try to work toward that, but I'm pretty sure there are plenty of
> devices that are initialized but not used in U-Boot already.

This "but there are other examples doing just the same!" arguing is
getting tiresome. Please accept that this is not an argument capable of
convincing people - the opposite is true.

Is there a technical reason why the initialization has to be in U-Boot?

Cheers
Detlev

--
Less talking -- more hacking
-- Olin Shivers
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de