From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] [NEXT] edminiv2: enable relocation
Date: Wed, 22 Sep 2010 11:38:36 +0200 [thread overview]
Message-ID: <4C99CE9C.20409@free.fr> (raw)
In-Reply-To: <4C99C8D7.30607@mvista.com>
Le 22/09/2010 11:13, Sergei Shtylyov a ?crit :
> Hello.
>
> On 21-09-2010 23:35, Albert Aribaud wrote:
>
>> Signed-off-by: Albert Aribaud<albert.aribaud@free.fr>
> [...]
>> diff --git a/board/LaCie/edminiv2/config.mk
>> b/board/LaCie/edminiv2/config.mk
>> index 3dec1aa..b4845ad 100644
>> --- a/board/LaCie/edminiv2/config.mk
>> +++ b/board/LaCie/edminiv2/config.mk
>> @@ -24,4 +24,6 @@
>> # MA 02110-1301 USA
>> #
>>
>> -TEXT_BASE = 0x00100000
>> +# with relocation TEXT_BASE now *must* be in FLASH
>> +
>
> Don't think this empty line is needed...
So be it :) -- I'll remove it.
>> +TEXT_BASE = 0xfff90000
>> diff --git a/include/configs/edminiv2.h b/include/configs/edminiv2.h
>> index ccfc660..a61e225 100644
>> --- a/include/configs/edminiv2.h
>> +++ b/include/configs/edminiv2.h
>> @@ -223,4 +223,10 @@
>> #define CONFIG_SYS_RESET_ADDRESS 0xffff0000
>> #define CONFIG_SYS_MAXARGS 16
>>
>> +/* additions for new relocation code, must added to all boards */
>
> Maybe "must be added"?
Thanks, I'll fix that in V2, and as this is copied from Heiko's patches,
I've forwarded this correction request to his series as well.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-09-22 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 19:35 [U-Boot] [PATCH 1/2] [NEXT] orion5x: fix relocation-incompatible code Albert Aribaud
2010-09-21 19:35 ` [U-Boot] [PATCH 2/2] [NEXT] edminiv2: enable relocation Albert Aribaud
2010-09-22 9:13 ` Sergei Shtylyov
2010-09-22 9:38 ` Albert ARIBAUD [this message]
2010-09-23 9:16 ` [U-Boot] [PATCH 1/2] [NEXT] orion5x: fix relocation-incompatible code Prafulla Wadaskar
2010-09-23 9:32 ` Albert ARIBAUD
2010-09-23 16:28 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C99CE9C.20409@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox