From: Nick Thompson <nick.thompson@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [NEXT] da830: fixup ARM relocation support
Date: Wed, 22 Sep 2010 15:15:09 +0100 [thread overview]
Message-ID: <4C9A0F6D.5040509@ge.com> (raw)
In-Reply-To: <AANLkTimn=J+x1sgZDDMYdBaNnKSX5CMD7DPXOKBRP4gw@mail.gmail.com>
On 22/09/10 14:43, Ben Gardiner wrote:
> On Wed, Sep 22, 2010 at 9:16 AM, Nick Thompson <nick.thompson@ge.com> wrote:
>> Fixes build breakage in da830evm after commit
>> 97003756249bd790910417eb66f0039bbf06a02c "da8xx: fixup ARM
>> relocation support"
>>
>> The da8xx fixup commit changed da830/da850 common code to make
>> relocation work in da850, but didn't add the required defines
>> to da830evm_config.h resulting in build failure in the common code.
>>
>> This patch adds those defines for da830, but makes no sense without
>> also referring to the commit mentioned above.
>>
>> Signed-off-by: Nick Thompson <nick.thompson@ge.com>
>
> Sorry that was my fault for not adding the needed changes to the da830
> config also when I submitted that patch.
It's not a problem - at least you laid the ground work for a fix that
had to be done anyway. I only mentioned it to put the patch in
context.
> What about removing "#define CONFIG_SKIP_RELOCATE_UBOOT" as in commit
> ab86f72c354f9b2572340f72b74ca0a258c451bd ?
Hmmm. It wouldn't hurt I guess. The UBL copies the code to the correct
address though doesn't it? The copy is not executed and so the code is
redundant - or did I miss something?
Nick.
next prev parent reply other threads:[~2010-09-22 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 13:16 [U-Boot] [PATCH] [NEXT] da830: fixup ARM relocation support Nick Thompson
2010-09-22 13:43 ` Ben Gardiner
2010-09-22 14:15 ` Nick Thompson [this message]
2010-09-22 15:07 ` Ben Gardiner
2010-09-22 15:15 ` Nick Thompson
2010-09-22 15:21 ` Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9A0F6D.5040509@ge.com \
--to=nick.thompson@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox