[U-Boot] [PATCH 2/2] [NEXT] arm926ejs: reduce code size with -msingle-pic-base

Ben Gardiner
2010-09-22T20:55:51Z

Hi Wolfgang,

On Wed, Sep 22, 2010 at 4:30 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Ben Gardiner,
>
> In message <AANLkTinK1PWePkBaBHEnxcyV6eOwtjZb-7+kA-JhHM9Z@mail.gmail.com> you wrote:
>>
>> I tried tested this on da850evm -- the da850evm.h has "#undef
>> CONFIG_SYS_ARM_WITHOUT_RELOC /* This board is tested with relocation
>> support */".
>
> This slipped through, sorry for that.
>
> That line must be removed.

I don't understand; I thought that '#undef' _enabled_ relocation
support. According to doc/README.arm-relocation on u-boot./next:

To compile a board without relocation, define CONFIG_SYS_ARM_WITHOUT_RELOC
This possibility will removed!! So please fix your board to compile without
CONFIG_SYS_ARM_WITHOUT_RELOC defined!!!

But I did test relocation on this board with Heiko and it is working
as-is on d70d8ccc200db8c16a6654cb726c3d74b6640b32 of u-boot/next; we
found that 97003756249bd790910417eb66f0039bbf06a02c made it work.

I can confirm that -- as you suggest -- the following applied to u-boot/next
diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
index d02b196..e0a3bae 100644
--- a/include/configs/da850evm.h
+++ b/include/configs/da850evm.h
@@ -138,7 +138,6 @@
#endif

/* additions for new relocation code, must added to all boards */
-#undef CONFIG_SYS_ARM_WITHOUT_RELOC /* This board is tested with
relocation support */
#define CONFIG_SYS_SDRAM_BASE 0xc0000000
#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_SDRAM_BASE
+ 0x1000 - /* Fix this */ \
CONFIG_SYS_GBL_DATA_SIZE)

also works on da850evm. But isn't this disabling the recently added
relocation support?

Best Regards,
Ben Gardiner

---
Nanometrics Inc.